fix: Enforce node 22, python 3.13 minimums, warn below node 24, python 3.14 - #35
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the action’s Node and Python configuration policy checks to enforce new minimum versions (Node 22+, Python 3.13+) while emitting warnings for versions below the recommended baselines (Node <24, Python <3.14), and plumbs those warnings through to GitHub Actions output.
Changes:
- Introduce a shared
ConfigCheckResultshape (violations + warnings) and surface warnings viacore.warning. - Update Node config checks to require Node >=22 and warn for Node 22/23 (recommended >=24).
- Add Python checks requiring a resolvable
.python-version(>=3.13; warn if 3.13) and validatingrequires-pythonwhen present.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/python-config.test.js | Updates existing tests for new return shape; adds tests for .python-version and requires-python validation and warning behavior. |
| test/node-config.test.js | Updates tests for new return shape and adds coverage for Node-version warnings below the recommended baseline. |
| src/index.ts | Collects and emits config warnings, and aggregates config violations from new result objects. |
| src/helpers/python-config.ts | Adds Python version policy checks for .python-version and requires-python, and returns warnings/violations via ConfigCheckResult. |
| src/helpers/node-config.ts | Adds recommended Node baseline warnings, lowers enforced minimum to Node 22, and returns ConfigCheckResult. |
| src/helpers/config-files.ts | Introduces shared finding/result types and helpers for splitting warnings vs violations. |
| README.md | Documents updated Node/Python policy rules and changes the default Python version input documentation. |
| dist/index.mjs | Rebuild output reflecting updated policy behavior (warnings + new minimums). |
| action.yml | Updates default python-version input to 3.14. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+4
to
+11
| pull_request_target: { types: [opened] } | ||
| issue_comment: { types: [created] } | ||
| pull_request_review: { types: [submitted] } | ||
|
|
||
| jobs: | ||
| merge-check: | ||
| uses: elementx-ai/workflows/.github/workflows/codeowners-merge.yaml@main | ||
| secrets: inherit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.